Verify the Pool connection is not nil before attempting to close it #480
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks to make sure the Pool's connection is not nil before attempting to close it (previously it was not checking so could get a panic for a nil deference. If looking at the Pool connection initialization code in
pool.go
:It can be seen that if the opts.InitialCap < opts.MaxOpen, then we allocate a connection slice of size
opts.MaxOpen
where onlyopts.InitialCap
are initially initialized. If we then close it later, it will cause the panic referred to above (can see stack trace in issue).Addresses: #479