Add support for configurable opening, closing quotes #8
Conversation
github-actions
bot
added
👋 phase/new
Codecov Report
@@ Coverage Diff @@
## main #8 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 384 411 +27
=========================================
+ Hits 384 411 +27
Continue to review full report at Codecov.
|
Co-authored-by: Titus <[email protected]>
| if (node.value === '`') { | ||
| node.value = '‘' | ||
| } else if (node.value === "'") { | ||
| node.value = '’' |
There was a problem hiding this comment.
hmm, good point, yes should probably be affected as well i think
There was a problem hiding this comment.
On the other hand, that isn’t about " (and ').
That would perhaps need “primary, secondary” options instead?
Easier to leave it as is for now?
There was a problem hiding this comment.
oh, ok should i revert 59d7be4 then?
Co-authored-by: Titus <[email protected]>
wooorm
changed the title
This comment has been minimized.
This comment has been minimized.
wooorm
added
🦋 type/enhancement
|
I’ll try and get a release done this weekend. Hoping to rework the docs and modernize things as well. |
|
Released in 5.2.0! |
Initial checklist
Description of changes
languages other than english might have other conventions for which characters to display for opening and closing quotes. this pr adds two options to make opening and closing quotes configurable.