Feature/track pseudo elements rebase #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support before and after. Support ::first-line and ::first-letter. Clean up java code to configure default values of pseudo elements
Old notation used escaped characters
This is all in one commit because the change and the tests are related. I originally made some minor changes during the rebasing to some commits in order to support changes made to the data structures in the Javascript. I extended the tests to make sure that hidden elements are handled correctly.
* There currently seems to be a reproducible problem with the TabIT tests which will always detect a deleted element. * The SimplePageDiffIT test used `fail()`, although it is not clear why that is necessary. Using this method will, indeed, fail the test every time. * RecheckRemoteWebElementFailingIT seems to insert or delete a wrong option. One of the tests does only succeed on Firefox. It looks a bit like a off-by-one error, but needs further investigation.
githubert
force-pushed
the
feature/track-pseudo-elements-rebase
branch
from
b88d8e6
to
3a4e4be
Compare
roesslerj
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submission, please check that ...
Description
This rebases the “Pseudo Elements” feature.
State of this PR
There are some tests that need more work, involving some potential bugs. Currently there is also a bit of debug output present which can probably be removed, but I think this is out of the scope of the rebase.
There is currently no documentation. I'm not sure if a note for the changelog should go in here, or maybe in a separate PR.