Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clients should assume http protocol #790

Closed
DonutEspresso opened this issue Apr 21, 2015 · 0 comments
Closed

clients should assume http protocol #790

DonutEspresso opened this issue Apr 21, 2015 · 0 comments
Labels

Comments

@DonutEspresso
Copy link
Member

When creating a new http client (JSON or otherwise), if the passed in host name doesn't have a http protocol you'll get an ECONNREFUSED error after about 5-10 seconds:

var client = restify.createJsonClient({
    url: 'www.google.com'
});

client.get('/', function() {...});

Should Restify assume http by default?

retrohacker pushed a commit that referenced this issue Apr 29, 2017
Closes:

#289
#381
#474
#575
#790
#633
#717
#576
#576
#909
#875
#860
#853
#850
#829
#813
#801
#921
#1101
#1019
#989
#632
#708
#737
#859
#1326
#1327
#927
#1099
#1068
#1040
#1035
#957
#948
#1134
#1136
#1183
#1206
#1286
#1323

> Note: this issue closes _but does not resolve_ the issues listed, we are just tracking them in another medium
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants