Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report symlink sizes from FUSE mount #3668

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Conversation

greatroar
Copy link
Contributor

What does this PR change? What problem does it solve?

Restic mount now correctly reports the sizes of symlinks. It also reports a non-zero block count for symlinks, just in case.

I tested it by using an actual mount of one of my backup repos., but I wasn't sure how to unit test this without just repeating the code.

Was the change previously discussed in an issue or on the forum?

Fixes #3667.

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • I have added tests for all code changes.
  • I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

Copy link
Member

@fd0 fd0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fd0 fd0 merged commit 8388f66 into restic:master Mar 21, 2022
@greatroar greatroar deleted the symlink-size branch March 7, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restic mount lists symlinks with size of zero
3 participants