Update tests to provision 3 nodes cluster tests with a replicated loglet with replication property 2 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
commented
Dec 23, 2024
Comment on lines
+24
to
26
| { | ||
| "moduleLicense": "COMMON DEVELOPMENT AND DISTRIBUTION LICENSE (CDDL) Version 1.0" | ||
| } |
There was a problem hiding this comment.
This license is needed for javax.annotation:javax.annotation-api which is pulled in by io.grpc:grpc-kotlin-stub. It should not be a problem since we are not changing the sources.
tillrohrmann
commented
Dec 23, 2024
| @@ -46,24 +46,28 @@ class RestateContainer( | |||
| private val WAIT_STARTUP_STRATEGY = | |||
| WaitAllStrategy() | |||
| .withStrategy( | |||
| Wait.forHttp("/restate/health") | |||
| .forPort(RUNTIME_INGRESS_ENDPOINT_PORT) | |||
| Wait.forHttp("/metrics") | |||
There was a problem hiding this comment.
/metrics will be reachable once the node grpc server starts up. Note at this point (if manual provisioning is enabled) the other services (ingress, admin, etc.) are not yet running.
…let with replication property 2 This commit adds the NodeCtl grpc svc to the repo to generate a grpc client to manually provision a replicated loglet with a replciation property 2. W/o manually provisioning the cluster, the replication property defaults to 1. Note: Whenever the *.proto files change in the restate repo, they need to be updated in this repository as well if there is an incompatible change. This fixes restatedev#26.
tillrohrmann
force-pushed
the
issues/26
branch
from
033cf50 to
2aa6f7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the NodeCtl grpc svc to the repo to generate a grpc client to manually provision a replicated loglet with a replciation property 2. W/o manually provisioning the cluster, the replication property defaults to 1.
Note: Whenever the *.proto files change in the restate repo, they need to be updated in this repository as well if there is an incompatible change.
This fixes #26.