Renamings #164
Merged
Renamings #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for creating this PR @slinkydeveloper. The renaming of the modules are a good simplification. I was wondering whether we should push it a bit further and remove sdk from our group id and call the sdks dev.restate:sdk-java and dev.restate:sdk-kotlin or dev.restate:restate-sdk-java and dev.restate:restate-sdk-kotlin, respectively.
README.md
Outdated
|
|
||
| ``` | ||
| implementation("dev.restate.sdk:sdk-kotlin:1.0-SNAPSHOT") | ||
| implementation("dev.restate.sdk:sdk-api-kotlin:1.0-SNAPSHOT") |
There was a problem hiding this comment.
Following the above comment: dev.restate:sdk-kotlin or dev.restate:restate-sdk-kotlin would be simplest, I believe.
Fix readme
tillrohrmann
approved these changes
Nov 27, 2023
Failures are on the e2e tests, will fix after merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements various renamings of modules/packages to be a bit more obvious: