-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always interact with ctx through facilitator functions #35
Conversation
4ac8539
to
6b76db0
Compare
2d25302
to
7ed640f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks so much better now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure facilitators is the right name anymore for this file :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meh idk what else to call it :D
// ObjectSend gets an Object send client by service name, key and method name | ||
func ObjectSend(ctx Context, service string, key string, method string, options ...options.ClientOption) SendClient[any] { | ||
return ctx.inner().Object(service, key, method, options...) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe not for now, but can we have Workflow/WorkflowSend too (you might want to call workflows built in TS for example)
No description provided.