Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always interact with ctx through facilitator functions #35

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

jackkleeman
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Aug 21, 2024

Test Results

  5 files  ±0    5 suites  ±0   2m 13s ⏱️ -3s
 41 tests ±0   41 ✅ ±0  0 💤 ±0  0 ❌ ±0 
101 runs  ±0  101 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 80c7df7. ± Comparison against base commit eb778c7.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@muhamadazmy muhamadazmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@slinkydeveloper slinkydeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so much better now!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure facilitators is the right name anymore for this file :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meh idk what else to call it :D

Comment on lines +58 to 61
// ObjectSend gets an Object send client by service name, key and method name
func ObjectSend(ctx Context, service string, key string, method string, options ...options.ClientOption) SendClient[any] {
return ctx.inner().Object(service, key, method, options...)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not for now, but can we have Workflow/WorkflowSend too (you might want to call workflows built in TS for example)

@jackkleeman jackkleeman merged commit f505c4c into main Aug 21, 2024
3 checks passed
@jackkleeman jackkleeman deleted the extra-facilitators branch August 21, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants