resolve RUSTSEC-2023-0086 #2004
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
force-pushed
the
resolve-RUSTSEC-2023-0086
branch
from
9f61e6a
to
f8dcaa2
Compare
tillrohrmann
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Thanks a lot for fixing the advisory @aradwann. This is really cool. Also that you could get rid of the nasty hack to convert between tonic 0.12 and 0.11 :-) The changes look good to me.
I've rebased your changes onto the latest main and removed the merge commits so that we have a linear commit history. Once GHA gives green light, I'll merge your changes. Thanks a lot for your contribution. You are awesome!
upgrade API breaking arrow dependencies fix SessionStateBuilder deprecation warnings replace closure with function remove unused tonic-0-11 cargo update upgrade arrow upgrade arrow convert This fixes #2004.
tillrohrmann
force-pushed
the
resolve-RUSTSEC-2023-0086
branch
from
f8dcaa2
to
b0f7090
Compare
igalshilman
added a commit
to igalshilman/restate
that referenced
this pull request
Oct 16, 2024
This is a bug fix that was introduced in restatedev#2004 Which change the order that optimizers are registered. The reason for this is described as a comment few lines above.
igalshilman
added a commit
that referenced
this pull request
Oct 17, 2024
* [datafusion] prepend physical_optimizer_rule before the other rules This is a bug fix that was introduced in #2004 Which change the order that optimizers are registered. The reason for this is described as a comment few lines above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1966 and #1655
awaiting apache/arrow-rs#6340