[datafusion] Update to the latest version #1673
Conversation
igalshilman
force-pushed
the
update_data_fusion
branch
from
e08b202
to
6a50dcc
Compare
igalshilman
requested review from
tillrohrmann
and removed request for
tillrohrmann
|
Needs a bit more testing. |
|
@igalshilman let me know when I should take a look at it. |
|
@tillrohrmann you can if you like, I'm now testing the CLI queries with it |
igalshilman
force-pushed
the
update_data_fusion
branch
from
6a50dcc
to
a167a27
Compare
There was a problem hiding this comment.
Thanks for upgrading our DF dependencies @igalshilman :-) The changes look good to me. +1 for merging.
| // hash_join | ||
| // .left() | ||
| // .properties() | ||
| // .output_ordering() | ||
| // .map(|s| s.to_vec()), | ||
| // hash_join | ||
| // .right() | ||
| // .properties() | ||
| // .output_ordering() | ||
| // .map(|s| s.to_vec()), |
There was a problem hiding this comment.
Can this be removed or do we want to keep it for documentation purposes?
| } | ||
|
|
||
| fn name(&self) -> &str { | ||
| "join_rewrite" | ||
| } | ||
|
|
||
| fn schema_check(&self) -> bool { | ||
| true | ||
| false |
There was a problem hiding this comment.
Out of curiosity: What is changing the schema so that we need to disable the schema check?
|
@igalshilman what were the problems you ran into regarding joins? We have encountered a problem with a Datafusion dependency which would be solved by upgrading our Datafusion dependency (see #1749 for more details). |
igalshilman
force-pushed
the
update_data_fusion
branch
from
a167a27
to
7c92b6f
Compare
igalshilman
force-pushed
the
update_data_fusion
branch
from
edf5bfd
to
12fae09
Compare
Updated data fusion to the latest version as part of #1655
Had to also update arrow-flight and transitively tonic.