Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Rocksdb performance tuning #1572

Merged
merged 1 commit into from
May 31, 2024
Merged

[Perf] Rocksdb performance tuning #1572

merged 1 commit into from
May 31, 2024

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented May 30, 2024

[Perf] Rocksdb performance tuning

This also introduces a change to how memory budgeting is configured and the default number of partitions is now 24


Stack created with Sapling. Best reviewed with ReviewStack.

Copy link

github-actions bot commented May 30, 2024

Test Results

 99 files  ±0   99 suites  ±0   7m 3s ⏱️ -39s
 83 tests ±0   83 ✅ ±0  0 💤 ±0  0 ❌ ±0 
212 runs  ±0  212 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit faab766. ± Comparison against base commit 854947e.

♻️ This comment has been updated with latest results.

This also introduces a change to how memory budgeting is configured and the default number of partitions is now 24
@AhmedSoliman
Copy link
Contributor Author

Tests fixed in the next PR in the stack

@AhmedSoliman AhmedSoliman marked this pull request as ready for review May 31, 2024 08:24
@AhmedSoliman AhmedSoliman merged commit faab766 into main May 31, 2024
11 of 13 checks passed
@AhmedSoliman AhmedSoliman deleted the pr1572 branch May 31, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant