Record nanos instead of millis for bifrost record creation time #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2024
AhmedSoliman
force-pushed
the
pr1544
branch
2 times, most recently
from
f6c140e
to
030f3b7
Compare
tillrohrmann
approved these changes
May 23, 2024
| // it's ~580 years from unix epoch until u64 wouldn't become sufficient to store nanos. | ||
| let t = NanosSinceEpoch::now().as_u64(); | ||
| assert!(t < u64::MAX); | ||
| println!("{:?}", t); |
There was a problem hiding this comment.
Is the println needed for anything?
There was a problem hiding this comment.
I don't really think so, it's just there to match the existing test. Maybe it was to avoid compiler optimizing it out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record nanos instead of millis for bifrost record creation time
Stack created with Sapling. Best reviewed with ReviewStack.