Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send x-restate-id header back on each request #1542

Merged
merged 2 commits into from
May 22, 2024
Merged

Send x-restate-id header back on each request #1542

merged 2 commits into from
May 22, 2024

Conversation

slinkydeveloper
Copy link
Contributor

Fix #1258

I'm gonna use this header in the java sdk to remove the parsing of the json object for the /send requests.

@slinkydeveloper slinkydeveloper mentioned this pull request May 22, 2024
Open
@slinkydeveloper
Copy link
Contributor Author

See restatedev/sdk-java#328

tillrohrmann
tillrohrmann approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for merging.

crates/ingress-http/src/handler/responses.rs Show resolved Hide resolved
@slinkydeveloper slinkydeveloper merged commit db544d3 into restatedev:main May 22, 2024
3 checks passed
@slinkydeveloper slinkydeveloper deleted the issues/1258 branch May 22, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Design] Add invocation ID to all response headers
2 participants
@slinkydeveloper @tillrohrmann