Set and validate supported service discovery protocol version #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 17, 2024
git-subtree-dir: crates/types/service-protocol git-subtree-split: 1898426fc98c16d704068594cd54394912845ff7
…pes/service-protocol'
Moving the restate-service-protocol types to restate-types makes it simpler to share them across different crates.
This commit introduces the selection of a service protocol version when starting the InvocationTask. The service protocol version is sent to the service endpoint via the content type and accept headers in the form of vnd.restate.invocation.vX. Additionally, we record the chosen service protocol version in the journal metadata for sanity checks. Note, currently we don't support resuming an invocation that was started on an older protocol version with a newer protocol version. This fixes restatedev#1510.
This commit sends the supported service discovery protocol version to a service endpoint as part of the accept headers and validates that the returned response is using a supported version (send via the content type header). This fixes restatedev#1523.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit sends the supported service discovery protocol version to a
service endpoint as part of the accept headers and validates that the
returned response is using a supported version (send via the content
type header).
This fixes #1523.
This PR is based on #1517