Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement /restate/invocation/{id}/attach and /restate/invocation/{id}/output #1503

Merged
merged 4 commits into from
May 21, 2024
Merged

Implement /restate/invocation/{id}/attach and /restate/invocation/{id}/output #1503

merged 4 commits into from
May 21, 2024

Commits on May 20, 2024

  1. Squash of the first part of the PR: 

    * Minor stuff
* We now correctly implement the distinction between get output and attach responses. This makes sure we don't complete pending attach with get output responses.
* Also deduplicated the ingress response types by adding a wrapping type for the target node.
* Another test, just in case, plus make sure the ingress dispatcher will try to unblock waiting responses both with idempotency id or invocation id
* Implement /restate/invocation/{id}/attach and /restate/invocation/{id}/output.
* Now the invocation id returned on /send with idempotency id is the one of the original invocation.
* Implement the new commands and the invocation id notification in the PP
* New ingress response variant to notify the invocation_id of an existing idempotent invocation. This is required to make sure that on /send idempotent requests requests, we return back the invocation_id of the invocation we "attach to" for a given idempotent invocation.
* New state machine command to attach to an existing invocation

Second part of the PR:

* Add InvocationStorageReader to implement GetOutput, remove the GetOutput command
* Send attach notification for workflow calls.
* Feedback

Add /workflow/.../output and /workflow/.../attach
    @slinkydeveloper
    slinkydeveloper committed May 20, 2024
    Configuration menu
    Copy the full SHA
    f2b02de View commit details
    Browse the repository at this point in the history

  2. Rebase

    @slinkydeveloper
    slinkydeveloper committed May 20, 2024
    Configuration menu
    Copy the full SHA
    3644643 View commit details
    Browse the repository at this point in the history

  3. Feedback

    @slinkydeveloper
    slinkydeveloper committed May 20, 2024
    Configuration menu
    Copy the full SHA
    80a6ef9 View commit details
    Browse the repository at this point in the history

  4. Rebase

    @slinkydeveloper
    slinkydeveloper committed May 20, 2024
    Configuration menu
    Copy the full SHA
    9e10002 View commit details
    Browse the repository at this point in the history