Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Side effects flush behaviour test #58

Merged
merged 3 commits into from
Aug 4, 2022
Merged

Side effects flush behaviour test #58

merged 3 commits into from
Aug 4, 2022

Conversation

slinkydeveloper
Copy link
Collaborator

@slinkydeveloper
Copy link
Collaborator Author

Tested locally and it works

tillrohrmann
tillrohrmann approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for merging.

...coordinator/impl/src/main/java/dev/restate/e2e/functions/coordinator/CoordinatorService.java Outdated Show resolved Hide resolved
@slinkydeveloper slinkydeveloper merged commit 598db23 into main Aug 4, 2022
@slinkydeveloper slinkydeveloper deleted the side-effects-overhaul branch August 4, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slinkydeveloper @tillrohrmann