Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for attach/getOutput #334

Merged
merged 4 commits into from
May 21, 2024
Merged

Test for attach/getOutput #334

merged 4 commits into from
May 21, 2024

Conversation

slinkydeveloper
Copy link
Collaborator

@slinkydeveloper slinkydeveloper commented May 3, 2024

Check for restatedev/restate#1495 and restatedev/restate#1494

  • Add an assertion in existing send test to make sure the invocation id is the same across idempotent invocations
  • Add test for attach/getOutput

Copy link

github-actions bot commented May 3, 2024

Test Results

 99 files  ±0   99 suites  ±0   8m 47s ⏱️ +13s
 84 tests ±0   82 ✅ ±0  2 💤 ±0  0 ❌ ±0 
215 runs   - 1  209 ✅  - 1  6 💤 ±0  0 ❌ ±0 

Results for commit 8221072. ± Comparison against base commit 338086b.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
dev.restate.e2e.JavaWorkflowAPITest ‑ Workflow cannot be submitted more than once
dev.restate.e2e.runtime.IngressTest ‑ Idempotent send then attach/getOutput

♻️ This comment has been updated with latest results.

@slinkydeveloper slinkydeveloper changed the title Make sure the invocation id is the same across idempotent invocations Test for attach/getOutput May 13, 2024
@slinkydeveloper
Copy link
Collaborator Author

Depends on restatedev/sdk-java#310

@slinkydeveloper slinkydeveloper merged commit 508b23f into main May 21, 2024
2 checks passed
@slinkydeveloper slinkydeveloper deleted the restate/issues/1495 branch May 21, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant