Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization guide for Typescript #448

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Serialization guide for Typescript #448

merged 2 commits into from
Aug 28, 2024

Conversation

slinkydeveloper
Copy link
Contributor

Fix #379

Copy link

cloudflare-workers-and-pages bot commented Aug 28, 2024

Deploying documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: e48d169
Status: ✅  Deploy successful!
Preview URL: https://520f9422.documentation-beg.pages.dev
Branch Preview URL: https://issues-379.documentation-beg.pages.dev

View logs

@slinkydeveloper
Copy link
Contributor Author

@gvdongen
Copy link
Contributor

gvdongen commented Aug 28, 2024

Maybe we should add an example of a Serde implementation as well? Just to show the template? Since the serializer you use here is actually still integrated in the Restate SDK.
For Python, I did this as follows: https://python-quickstart.documentation-beg.pages.dev/develop/python/serialization
Or do you think that is too much?

Copy link
Contributor

@gvdongen gvdongen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides that LGTM 👍

@slinkydeveloper
Copy link
Contributor Author

slinkydeveloper commented Aug 28, 2024

I think it's ok, it's a simple enough interface, people will figure out themselves, no need to overload the docs.

@slinkydeveloper
Copy link
Contributor Author

What I think would help tough is serving the tsdocs, so we could link the Serde interface from here and one could immediately see how it looks like.

@slinkydeveloper slinkydeveloper merged commit 4fe82f7 into main Aug 28, 2024
2 checks passed
@slinkydeveloper slinkydeveloper deleted the issues/379 branch August 28, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Raw handlers and Accept annotation
2 participants