Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert the Tour to new API and general improvements #348

Merged
merged 9 commits into from
Apr 18, 2024
Merged

Convert the Tour to new API and general improvements #348

merged 9 commits into from
Apr 18, 2024

Conversation

gvdongen
Copy link
Contributor

@gvdongen gvdongen commented Apr 12, 2024 •
edited
Loading

Fixes #257 and #238

  • Add usage of CLI
  • Improve explanation of durable execution
  • Improve messaging based on recent changes
  • Add virtual objects and move that explanation down to the state section
  • Use new API
  • Rewrite text to reflect new API
  • Make style nicer
  • Change names to TicketObject, CartObject, and CheckoutService

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Apr 12, 2024 •
edited
Loading

Deploying documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 85082c2
Status: ✅  Deploy successful!
Preview URL: https://691ad7c4.documentation-beg.pages.dev
Branch Preview URL: https://tour-new-api.documentation-beg.pages.dev

View logs

@gvdongen gvdongen changed the base branch from main to dev_0.9 April 12, 2024 07:43
@gvdongen gvdongen marked this pull request as ready for review April 17, 2024 06:53
@gvdongen gvdongen mentioned this pull request Apr 17, 2024
Merged
slinkydeveloper
slinkydeveloper reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@slinkydeveloper slinkydeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left mostly small comments, i like it, it looks very good!!!

Maybe one last comment i have is whether it completes the story to briefly mention somewhere idempotent requests from the ingress. You discuss about idempotency in the section with side effects, but perhaps it's just two faces of the same medal to say "actually you can do idempotent requests from the ingress too!"

docs/get_started/tour.mdx Outdated Show resolved Hide resolved
docs/get_started/tour.mdx Outdated Show resolved Hide resolved
docs/get_started/tour.mdx Outdated Show resolved Hide resolved
docs/get_started/tour.mdx Outdated Show resolved Hide resolved
docs/get_started/tour.mdx Outdated Show resolved Hide resolved
docs/get_started/tour.mdx Outdated Show resolved Hide resolved
docs/get_started/tour.mdx Show resolved Hide resolved
docs/get_started/tour.mdx Show resolved Hide resolved
docs/get_started/tour.mdx Show resolved Hide resolved
docs/get_started/tour.mdx Show resolved Hide resolved
gvdongen added 2 commits April 18, 2024 13:51
@gvdongen
Address feedback
7360b53
@gvdongen
Merge remote-tracking branch 'origin/dev_0.9' into tour_new_api
85082c2 
# Conflicts:
#	code_snippets/java/build.gradle.kts
#	docs/get_started/tour.mdx
@gvdongen gvdongen merged commit 5b5a43a into dev_0.9 Apr 18, 2024
1 check passed
@gvdongen gvdongen deleted the tour_new_api branch April 18, 2024 12:02
This was referenced Apr 23, 2024
Closed
Closed
slinkydeveloper pushed a commit that referenced this pull request Apr 25, 2024
@gvdongen @slinkydeveloper
Convert the Tour to new API and general improvements (#348)
c60501d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slinkydeveloper slinkydeveloper slinkydeveloper left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CLI to the Tour of Restate
2 participants
@gvdongen @slinkydeveloper