Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential issue in pre-commit submodule hooks #227

Merged
merged 1 commit into from
May 25, 2022
Merged

Fix potential issue in pre-commit submodule hooks #227

merged 1 commit into from
May 25, 2022

Conversation

juanangp
Copy link
Member

@juanangp juanangp commented May 25, 2022 •
edited by pull-request-badge bot
Loading

juanangp Ok: 4

Found in rest-for-physics/geant4lib#50 (comment) that pre-commit hooks are not working for submodules in case cmake was performed between these 2 PR:

Now the existence of the pre-commit submodule hook is checked every time, independenty of the pre-commmit present in framework

@juanangp juanangp requested review from jgalan and lobis May 25, 2022 10:55
@juanangp juanangp mentioned this pull request May 25, 2022
Merged
@juanangp juanangp merged commit 35c3f4d into master May 25, 2022
@juanangp juanangp deleted the submodule-pre-commit-fix branch May 25, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgalan jgalan jgalan approved these changes

@lobis lobis lobis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juanangp @jgalan @lobis