Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of generic Mongo params via connection string #356

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

ableegoldman
Copy link
Contributor

@ableegoldman ableegoldman commented Sep 27, 2024

Wanted to be able to set a higher connection idle timeout. Might as well take the opportunity to allow configuration of all the Mongo params via the connection string, rather than adding them one by one.

Context: saw this in an Antithesis run of the regression test:

org.apache.kafka.streams.errors.StreamsException: com.mongodb.MongoSocketReadException: Prematurely reached end of stream

According to some brief googling, this suggests the Mongo connection closed due to being idle. I'm guessing this is an effect of the chaos testing

@ableegoldman ableegoldman changed the title Increase max.connection.idle for Mongo Allow configuration generic Mongo params via connection string Sep 30, 2024
@ableegoldman ableegoldman changed the title Allow configuration generic Mongo params via connection string Allow for configuration of generic Mongo params via connection string Sep 30, 2024
@ableegoldman ableegoldman changed the title Allow for configuration of generic Mongo params via connection string Allow configuration of generic Mongo params via connection string Sep 30, 2024
Copy link
Contributor

@rodesai rodesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ableegoldman ableegoldman merged commit 14e8e1a into main Sep 30, 2024
1 check passed
@ableegoldman ableegoldman deleted the FIX-increase-mongo-max-connection-idle branch September 30, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants