KAFKA-15215: KIP-954, fully customizable default DSL store type #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ableegoldman
changed the title
ableegoldman
commented
Jul 20, 2023
| } else { | ||
| switch (materialized.storeType()) { | ||
| case IN_MEMORY: | ||
| supplier = Stores.inMemorySessionStore( | ||
| materialized.storeName(), | ||
| Duration.ofMillis(retentionPeriod) |
There was a problem hiding this comment.
@agavra see this for example
ableegoldman
pushed a commit
that referenced
this pull request
Nov 30, 2023
This change introduces some basic clean up and refactoring for forthcoming commits related to the revised fetch code for the consumer threading refactor project. Reviewers: Christo Lolov <[email protected]>, Jun Rao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC to accompany KIP-954
See KAFKA-15215