-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and tidy the flake definition. #13
Draft
plietar
wants to merge
6
commits into
main
Choose a base branch
from
flake-parts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a bunch of duplication in the deploy/start-vm/diff scripts left over from the introduction of the wpia-packit-private machine. These script now only exist as one script, that accepts a machine name as their argument. In order to split up the `flake.nix` file, it makes use of the [`flake-parts`][flake-parts] library. This library uses the same module system as NixOS itself, but at the flake configuration level itself. The deploy script is changed from using `nixos-rebuild switch` to our own implementation of it. The primary goal of this is to ensure the derivation of the built system gets deployed too, allowing us to reliable diff the system state in the future. [flake-parts]: https://flake.parts/
Comparing system configuration for wpia-packit against main branch
Comparing system configuration for wpia-packit-private against main branch
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a bunch of duplication in the deploy/start-vm/diff scripts left over from the introduction of the wpia-packit-private machine. These script now only exist as one script, that accepts a machine name as their argument.
In order to split up the
flake.nix
file, it makes use of theflake-parts
library. This library uses the same module system as NixOS itself, but at the flake configuration level itself.The deploy script is changed from using
nixos-rebuild switch
to our own implementation of it. The primary goal of this is to ensure the derivation of the built system gets deployed too, allowing us to reliable diff the system state in the future.