Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused output to remove warning #260

Merged
merged 3 commits into from
May 3, 2023
+9 −10
Merged

fix: remove unused output to remove warning #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7614d67
fix: remove unused output to remove warning
prescottprue May 2, 2023
8806598
Merge branch 'main' into remove-output
prescottprue May 2, 2023
1814734
fix: pin
prescottprue May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ inputs:
flag-name:
description: 'Flag name'
required: false
outputs:
coveralls-url:
description: 'URL for Coveralls build'
runs:
using: 'node16'
main: 'dist/index.js'
Expand Down
5 changes: 3 additions & 2 deletions dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20118,7 +20118,6 @@ const github_1 = __nccwpck_require__(5438);
const coveralls_api_1 = __importDefault(__nccwpck_require__(6398));
/**
* Report coverage to Coveralls for base branch
*
* @param lcovPath - Path to lcov file
*/
async function reportToCoveralls(lcovPath) {
Expand Down Expand Up @@ -20146,7 +20145,9 @@ async function reportToCoveralls(lcovPath) {
throw new Error(response.message);
}
core.info(`Successfully uploaded base coverage to Coveralls for branch "${branch}". Coveralls URL: ${response?.url}`);
core.setOutput('coverage-url', response?.url);
// NOTE: Removed because @actions/core uses deprecated set output command internally
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any alternate available to replace setOutput?

// See: https://github.com/actions/toolkit/issues/1336#issuecomment-1502056286
// core.setOutput('coverage-url', response?.url);
}
catch (err) {
const error = err;
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"@side/eslint-config-base": "1.0.0",
"@side/eslint-config-jest": "1.0.0",
"@side/prettier-config": "1.0.0",
"@side/semantic-config-base": "^0.0.1",
"@side/semantic-config-base": "0.0.1",
"@tsconfig/node16": "1.0.3",
"@types/jest": "29.5.1",
"@types/node": "16.18.25",
Expand Down
5 changes: 3 additions & 2 deletions src/coveralls.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ type ActualPostJobResponse = (PostJobResponse & { error: boolean }) | null;

/**
* Report coverage to Coveralls for base branch
*
* @param lcovPath - Path to lcov file
*/
export async function reportToCoveralls(lcovPath: string) {
Expand Down Expand Up @@ -49,7 +48,9 @@ export async function reportToCoveralls(lcovPath: string) {
core.info(
`Successfully uploaded base coverage to Coveralls for branch "${branch}". Coveralls URL: ${response?.url}`,
);
core.setOutput('coverage-url', response?.url);
// NOTE: Removed because @actions/core uses deprecated set output command internally
// See: https://github.com/actions/toolkit/issues/1336#issuecomment-1502056286
// core.setOutput('coverage-url', response?.url);
} catch (err) {
const error = err as Error;
core.error(`Error uploading lcov to Coveralls: ${error.message}`);
Expand Down
4 changes: 2 additions & 2 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1264,7 +1264,7 @@ __metadata:
"@side/eslint-config-base": 1.0.0
"@side/eslint-config-jest": 1.0.0
"@side/prettier-config": 1.0.0
"@side/semantic-config-base": ^0.0.1
"@side/semantic-config-base": 0.0.1
"@tsconfig/node16": 1.0.3
"@types/jest": 29.5.1
"@types/node": 16.18.25
Expand Down Expand Up @@ -1358,7 +1358,7 @@ __metadata:
languageName: node
linkType: hard

"@side/semantic-config-base@npm:^0.0.1":
"@side/semantic-config-base@npm:0.0.1":
version: 0.0.1
resolution: "@side/semantic-config-base@npm:0.0.1"
dependencies:
Expand Down