Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tailwind): extract pseudo classes to stylesheet #1864

Open
wants to merge 25 commits into
base: canary
Choose a base branch
from
Open

feat(tailwind): extract pseudo classes to stylesheet #1864

wants to merge 25 commits into from

Conversation

Sjoertjuh
Copy link

Solves the following discussion: #1338

This extracts pseudo classes like :hover to the stylesheet.

renovate bot and others added 3 commits December 10, 2024 10:27
@renovate @gabrielmfern
chore(deps): update dependency @changesets/cli to v2.27.10 (resend#1794)
aaabd3e 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@dependabot @gabrielmfern
chore(deps): bump next from 14.2.3 to 15.0.4 (resend#1810)
cb24580 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Sjoertjuh
feat(tailwind): extract pseudo classes to stylesheet
4b0d2ae
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: c78b55d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@react-email/tailwind Minor
@react-email/components Patch
react-email-with-aws-ses Patch
react-email-with-mailersend Patch
react-email-with-nodemailer Patch
react-email-with-plunk Patch
react-email-with-postmark Patch
react-email-with-resend Patch
react-email-with-sendgrid Patch
react-email-with-next-scaleway Patch
react-email-with-node-scaleway Patch
react-email-starter Patch
create-email Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 13, 2025

@Sjoertjuh is attempting to deploy a commit to the resend Team on Vercel.

A member of the Team first needs to authorize it.

@AshotN @dependabot @gabrielmfern
fix(react-email): Respect user NODE_ENV (resend#1756)
1748335 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: gabriel miranda <[email protected]>
@gabrielmfern gabrielmfern force-pushed the feature/extract-tailwind-pseudo-classes branch from 9a66e12 to fe2573d Compare January 14, 2025 11:47
gabrielmfern
gabrielmfern requested changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@gabrielmfern gabrielmfern left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, really nice! We planned on having this at some point, so this is really helpful!

One thing that still needs an adjustment is when the user has a media query with pseudo selectors as well, I also added in a change in the tests that currently fails to ensure that this works.

https://github.com/Sjoertjuh/react-email/blob/a15b0b014e60d19b17e3f25f0cc6fd2e20578e77/packages/tailwind/src/tailwind.spec.tsx#L404-L409

Another thing I'd like improvement is the duplicated code between the sanitization of media queries and of the pseudo selectors, since they seem to be mostly the same.

@Sjoertjuh
Copy link
Author

I indeed forgot that you could mix media queries with pseudo classes, so I added that. Also the change in the test was not completely correct, so that is updated as well.
I don't have too much time at the moment, so I'll have a look later if some parts could be shared between the two (or maybe even put into a single function)

@gabrielmfern gabrielmfern force-pushed the canary branch 3 times, most recently from d36385e to 7e7c5b0 Compare January 22, 2025 12:41
AshotN and others added 9 commits January 22, 2025 12:10
@AshotN @dependabot @gabrielmfern
fix(react-email): Respect user NODE_ENV (resend#1756)
cde2372 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: gabriel miranda <[email protected]>
@gabrielmfern
fix(react-email): Active state for root emails not appearing
ef85014
@bukinoshita @dependabot @gabrielmfern
fix(all): Use optional chain (resend#1820)
c01b9ad 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: gabriel miranda <[email protected]>
@bukinoshita @dependabot @gabrielmfern
chore(all): use biome (resend#1833)
0aea791 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: gabriel miranda <[email protected]>
@gabrielmfern @bukinoshita @dependabot
fix(render): Prettier breaking if mso comments (resend#1839)
840f1fc 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Bu Kinoshita <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@LucianBuzzo @dependabot @gabrielmfern
chore: upgrade esbuild (resend#1817)
12d007e 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: gabriel miranda <[email protected]>
@renovate @gabrielmfern
chore(deps): update dependency vite to v5.4.12 [security] (resend#1873)
25d67a7 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@gabrielmfern
chore(root): Bump for canary release (resend#1875)
0763b87
@dependabot @gabrielmfern
chore(deps-dev): bump vite from 5.4.12 to 5.4.13 (resend#1876)
0c79f23 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@renovate @gabrielmfern
fix(deps): update dependency tinybench to v3 (resend#1868)
ee6d8fb 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: gabriel miranda <[email protected]>
@Sjoertjuh Sjoertjuh force-pushed the feature/extract-tailwind-pseudo-classes branch from b466e15 to aef20d1 Compare January 23, 2025 19:30
@Sjoertjuh
Copy link
Author

I extracted some common logic from the two functions. Let me know if this is alright!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielmfern gabrielmfern Awaiting requested review from gabrielmfern

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Package: @react-email/tailwind
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sjoertjuh @gabrielmfern @AshotN @bukinoshita @LucianBuzzo