fix(render): Prettier cutting off templates under certain conditions #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a8e61f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gabrielmfern
force-pushed
the
fix/preview-rendering-bug
branch
from
0074f91 to
bca76ce
Compare
gabrielmfern
force-pushed
the
canary
branch
2 times, most recently
from
bf3f899 to
1748335
Compare
vcapretz
reviewed
Jan 22, 2025
gabrielmfern
force-pushed
the
canary
branch
2 times, most recently
from
a8d97ed to
d36385e
Compare
gabrielmfern
force-pushed
the
fix/preview-rendering-bug
branch
from
bca76ce to
fa72552
Compare
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: gabriel miranda <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: gabriel miranda <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: gabriel miranda <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Bu Kinoshita <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: gabriel miranda <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern
force-pushed
the
fix/preview-rendering-bug
branch
2 times, most recently
from
6453d87 to
41ad404
Compare
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: gabriel miranda <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… space characters from Preview
gabrielmfern
force-pushed
the
fix/preview-rendering-bug
branch
from
41ad404 to
a284191
Compare
vcapretz
reviewed
Jan 22, 2025
| 'utf8', | ||
| ); | ||
|
|
||
| expect(await pretty(stripeHTML)).toMatchSnapshot(); |
There was a problem hiding this comment.
Suggested change
| expect(await pretty(stripeHTML)).toMatchSnapshot(); | |
| expect(pretty(stripeHTML)).toMatchSnapshot(); |
vcapretz
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1785.
The issue was specifically when using React 18 and rendering with the
prettyoption enabled, particularly happening in the preview server.For some time I've noticed that React 18 seems to, for some reason, sometimes include null-byte characters in between certain chunks of HTML. The problem in this situation was then that Prettier also would give up on parsing the AST once it found one null-byte character for some reason.
To fix it, I ended up simply replacing all
\0characters with nothing right before inputting the HTML to the Prettier'sformatfunction. We can see this fixes the issue by looking at the test I added and adding a global override for using React 18 instead of 19.