fix(render): Null characters in between chunks #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 2617a25 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🤯 |
zehfernandes
approved these changes
Sep 26, 2024
gabrielmfern
added a commit
that referenced
this pull request
Sep 26, 2024
gabrielmfern
added a commit
that referenced
this pull request
Oct 1, 2024
gabrielmfern
added a commit
that referenced
this pull request
Oct 1, 2024
gabrielmfern
added a commit
that referenced
this pull request
Oct 8, 2024
gabrielmfern
added a commit
that referenced
this pull request
Oct 11, 2024
gabrielmfern
added a commit
that referenced
this pull request
Oct 14, 2024
gabrielmfern
added a commit
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1667 and the issue Resend was having in Broadcasts.
The problem was that, in React 18, chunks were probably being separated in a way that broke
up bytes that would make up a single character. This ended up resulting the TextDecoder using
null byte characters, as it could not properly decode the characters out.
This PR fixes the problem mentioned above by first adding up all chunks of Uint8Arrays into a single
Uint8Array to then be decoded. This fixes the issue that was happening and makes this a bit
more trustworthy.
The PR also adds in a unit test, but the test passes without the fix since it uses React 19, and apparently,
React 19 does not have the same issue that React 18 did.