Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in watch mode, clear the screen upon rebuilding #3402

Merged
merged 2 commits into from
Mar 1, 2019

Conversation

mengwong
Copy link
Contributor

@mengwong mengwong commented Mar 1, 2019

Without a screen refresh, watch mode fills the terminal with a scroll of build errors and warnings. It is not easy to see where the most recent build started; scanning upwards for ">>>> Start compiling" is cognitively taxing. So now we clear the screen each time watch mode decides to rebuild. Thanks @varunpatro for working with me on this. This pull request is a one-line change, but it took a while to get here!

@mengwong
Copy link
Contributor Author

mengwong commented Mar 1, 2019

it may be desirable in future to add a command line flag or environment variable to make this optional; see for example jestjs/jest#2959

mengwong added a commit to mengwong/bucklescript.github.io that referenced this pull request Mar 1, 2019
related to rescript-lang/rescript#3402

I'm not sure this chunk of documentation is exposed on the website
though -- can a user even navigate to this page from the home page?
@bobzhang bobzhang merged commit 1ba584d into rescript-lang:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants