Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves react lite theme loader's path resolver #2950 #2954

Closed
wants to merge 1 commit into from
Closed

Improves react lite theme loader's path resolver #2950 #2954

wants to merge 1 commit into from

Conversation

vkammerer
Copy link

No description provided.

@vkammerer vkammerer mentioned this pull request Jul 18, 2018
Closed
bobzhang
bobzhang reviewed Jul 19, 2018
View reviewed changes
Copy link
Member

@bobzhang bobzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff looks nice to have, but I am not an expert in understanding package.json, can you add some comments explaining each diff, thanks!

jscomp/bsb/templates/react-lite/loader.js
var idNodeModulesPrefix = './node_modules/' + id
var link = getPathWithJsSuffix(idNodeModulesPrefix, parent)
if (!id.includes("/")) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this mean, is it an ad-hoc optimization?

@vkammerer vkammerer closed this Jul 19, 2018
@vkammerer
Copy link
Author

PR cancelled because #2950 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobzhang bobzhang bobzhang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vkammerer @bobzhang