Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsb -make-world -w -ws _ fails after a few seconds #2974

Closed
joefiorini opened this issue Jul 31, 2018 · 2 comments
Closed

bsb -make-world -w -ws _ fails after a few seconds #2974

joefiorini opened this issue Jul 31, 2018 · 2 comments

Comments

@joefiorini
Copy link

I'm running macOS High Sierra 10.13.5 on node 10.7. I ran bsb -init -theme react-lite to create a new react lite app, installed dependencies via yarn, started serving the static code using http-server. I can visit the app and I get a bevvy of 404s in the console (possibly unrelated and already documented in #2950) including that the websocket server is not running (makes sense). Everything is fine up to this point. Then I ran yarn start to start the app. I get normal output:

⊗ yarn start
yarn run v1.9.2
$ bsb -make-world -w -ws _
[14/14] Building src/ReactDOMRe.mlast.d
[7/7] Building src/ReactDOMRe.cmj
>>>> Start compiling
[7/7] Building src/Component2.mlast.d
[3/3] Building src/Index-ReactLite.cmj
>>>> Finish compiling

And I can even refresh the page and it will connect to the websocket server. However, without changing any code, after I let it sit a few seconds the bsb -make-world -w -ws _ command will eventually fail with no error.

Sorry to be so light on details. I'll try to dig into the websocket code later if I can. Just want to get something reported and see if anyone has found a workaround for this. Thanks!

@bobzhang
Copy link
Member

@joefiorini thanks for the info. Is there any way we can reproduce this? More info would be appreciated as I can not reproduce it on my computer

bobzhang added a commit that referenced this issue Aug 10, 2018
Remove deprecated API, defensive, tentative fix of #2974
@bobzhang
Copy link
Member

can you check this is fixed in master, feel free to open it if it still does not work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants