Improve the dx of running the code analyzer some #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zth
commented
May 29, 2024
zth
commented
- Remove autostart feature. Some users have accidentally enabled it and then had annoying experiences.
- Add another reanalyze message that triggers the removal code action.
- Optimistically remove diagnostic as the removal code actions are applied.
- Show that code analysis is currently running in the status bar. This is to give some feedback as running the code analyzer can take some time in itself, and that it needs to run after compilation (which can take some time as well).
cristianoc
approved these changes
May 29, 2024
jfrolich
pushed a commit
to jfrolich/rescript-vscode
that referenced
this pull request
Sep 3, 2024
* improve the dx of running the code analyzer some * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.