Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental typechecking #939

Merged
merged 14 commits into from
Mar 5, 2024
Merged

Incremental typechecking #939

merged 14 commits into from
Mar 5, 2024

Conversation

zth
Copy link
Collaborator

@zth zth commented Mar 3, 2024

A first, experimental and opt in version of incremental typechecking. Still things to iron out, but should be enough to get some testing going.

Activate in the settings dialogue (beta/experimental) Enable incremental type checking..

incremental-typechecking.mp4

@zth zth force-pushed the incremental-typechecking branch from 8bcb1fc to 7b0deba Compare March 4, 2024 08:39
@zth zth changed the title [WIP] Incremental typechecking Incremental typechecking Mar 4, 2024
@zth zth requested a review from cristianoc March 4, 2024 19:36
@zth zth marked this pull request as ready for review March 4, 2024 19:36
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magic

@zth zth merged commit 40887dc into master Mar 5, 2024
4 checks passed
@zth zth deleted the incremental-typechecking branch March 5, 2024 20:45
@Mng12345
Copy link

Mng12345 commented Mar 6, 2024

This is amazing!

@Mng12345
Copy link

Mng12345 commented Mar 6, 2024

@zth Hi, did you forget to publish the extension to vscode extension market?

@fhammerschmidt
Copy link
Member

@Mng12345 Maybe you forgot to enable it in settings? Works for me with the latest pre-release version (v1.43.4)
"rescript.settings.incrementalTypechecking.enabled": true

@Mng12345
Copy link

Mng12345 commented Mar 6, 2024

It works now after the extension was updated 20minutes before.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants