Look up and propagate ReScript version #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uncurried by default properly
cristianoc
approved these changes
Dec 15, 2023
I added some justification in the original description. But I'm not terribly happy with it. |
cknitt
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we can default uncurried by default properly.
Ideally this would be done entirely in the analysis bin, but given that I don't want to mess with the logic of finding and executing the ReScript binary, I think it's fine that it's propagated through an env variable for now, given that the logic lives in the LS server itself (so vim and other LS users won't have to have their own logic).
Closes #863