Turn off uncurried #778
Open
Turn off uncurried #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
commented
May 26, 2023
| @@ -918,13 +918,13 @@ Path Js.n | |||
| "label": "nullable", | |||
| "kind": 22, | |||
| "tags": [], | |||
| "detail": "type nullable<+'a>", | |||
| "documentation": {"kind": "markdown", "value": "\n A value of this type can be undefined, null or 'a. This type is equivalent to Js.Null_undefined.t.\n"} | |||
| "detail": "type nullable<'a> = Value('a) | Null | Undefined", | |||
There was a problem hiding this comment.
@zth we lost the + here.
There was a problem hiding this comment.
Right, that's... weird. Don't think we changed the + in the implementation...
There was a problem hiding this comment.
Looks like this is the intended printing, inherited from OCaml, which only prints the + when the type is abstract:
# type 'a t1;;
type 'a t1
# type +'a t2;;
type +'a t2
# type +'a t2 = | A;;
type 'a t2 = AThere was a problem hiding this comment.
Interesting! That's good to know 😀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #777 but where unhurried is turned off.