Jsxtags: shaded brackets in JSX, just like TS does. #368

cristianoc · 2022-03-16T08:53:37Z

No description provided.

…uments, binary operators.

With upper case ids, emit Token.JsxTag With lower case ids, emit Token.Variable Still need to do module declarations and expressions (and e.g. open M etc).

…e into semantic-highlighting

This handles the case of labels whose location is not recoverable just from the AST: - function definitions `(~label as name)` - function calls `~label = 10` - component props `prop = 42`

This is done in two places: The textmate grammar handles the cases that can be figured out locally: - "<" in "<div ..." - "</" - "/>" - "<>" - "</>" Semantic highlighting handles the cases that cannot be figured out locally: - ">" in "<div __props__>" - ">" in "</div>" These cases can't be figures out locally as on the lhs of ">" there could be pretty much anything.

cristianoc and others added 30 commits March 9, 2022 13:52

Test vendoring the entire parser.

b2d5ca3

Complete vendoring of necessary compiler libs.

af57911

Add test command to parse a file.

1d3515e

Separate parser test.

8b3a4e7

Add part of core logic to recognise JSX uppercase/lowercase, type arg…

e42016c

…uments, binary operators.

Basic setup of extension analysis bin communication.

9b7d8d9

From https://github.com/zth

Simple token emitter

d854773

Pass current file contents to binary command.

5fb6fc2

Use an ast mapper.

6fca52b

Semantic highlighting for JSX open and close.

2bf41ca

Emit variables.

7d18906

Add token type "variable".

142d03d

Emitting types too.

547ae25

add sample highlight files

3c5119b

add explicit semantic token for JSX tag

31b603e

Emit long idents in expressions, patterns, and jsx labels, uniformly.

77dae25

With upper case ids, emit Token.JsxTag With lower case ids, emit Token.Variable Still need to do module declarations and expressions (and e.g. open M etc).

Rename JsxTag to Module.

40a1511

Other cases of module declarations and expressions.

73879ae

For module types, use Token.Type.

ede6f86

Add token type to debug print.

8658618

Use JsxTag for lower-case jsx, and Namespace for modules.

4faa239

Extend example file.

8ec7e31

Extend example.

6645df7

Emit record labels as "property".

cc4a0d3

Emit variants as enumMember.

a91494f

change let coloring to keyword, not control

d4ceba1

Merge branch 'semantic-highlighting' of github.com:zth/rescript-vscod…

2140178

…e into semantic-highlighting

more samples

a9de07c

Fix issue with function definitions that use labeled arguments.

e12db8d

tweak example file

61408d5

cristianoc and others added 9 commits March 14, 2022 16:09

Fix recursion in jsx props and children.

36d6747

Mark identifiers as variable by default.

1dba34a

This handles the case of labels whose location is not recoverable just from the AST: - function definitions `(~label as name)` - function calls `~label = 10` - component props `prop = 42`

Update rescript.tmLanguage.json

3efe079

Tweak example.

bbe1622

set explicit scope for true/false

14f7640

add nested sample

7a168b1

add nested sample to TS file as well

d0daa2b

samples for interpolated strings

0db650c

set template-expression scope for interpolated strings

779c890

cristianoc force-pushed the jsxtags branch from 8514193 to 3abef20 Compare March 16, 2022 08:55

cristianoc added 3 commits March 16, 2022 10:05

Tweak test: nested.

228374c

Fix issue with closing tag of nested components.

b44828c

cristianoc force-pushed the jsxtags branch from 3abef20 to 9db5562 Compare March 16, 2022 09:08

cristianoc closed this Mar 16, 2022

cristianoc deleted the jsxtags branch March 16, 2022 09:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jsxtags: shaded brackets in JSX, just like TS does. #368

Jsxtags: shaded brackets in JSX, just like TS does. #368

cristianoc commented Mar 16, 2022

Jsxtags: shaded brackets in JSX, just like TS does. #368

Jsxtags: shaded brackets in JSX, just like TS does. #368

Conversation

cristianoc commented Mar 16, 2022