Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where doc comment is not shown on hover in case of shadowed identifier #621

Closed
cristianoc opened this issue Nov 3, 2022 · 0 comments
Closed

Fix issue where doc comment is not shown on hover in case of shadowed identifier #621

cristianoc opened this issue Nov 3, 2022 · 0 comments

Comments

@cristianoc
Copy link
Collaborator

Example:

module CC = {
  /** First Comment */
  let a = 10

  /** Second Comment */
  let a = a
}

let q = CC.a // does not show comment on hover

See rescript-lang/syntax#715
cristianoc added a commit that referenced this issue Nov 3, 2022
@cristianoc
Add example showing how shadowing affects hovering on doc comments.
7518db6 
See #621
@cristianoc cristianoc mentioned this issue Nov 3, 2022
Merged
cristianoc added a commit that referenced this issue Nov 3, 2022
@cristianoc
Restore doc comment when there is a shadowed identifier.
5d11d5a 
Fixes #621
@cristianoc cristianoc changed the title Doc comments not shown then an id is shadowed. Fix issue where doc comment is not shown on hover in case of shadowed identifier Nov 3, 2022
@cristianoc cristianoc mentioned this issue Nov 3, 2022
Closed
cristianoc added a commit that referenced this issue Nov 3, 2022
@cristianoc
Add example showing how shadowing affects hovering on doc comments.
34a654e 
See #621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cristianoc