-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Int: Add bitwise functions from Pervasives #245
Conversation
0628354
to
8b507d2
Compare
@cometkim fyi |
BigInt needs this too |
BigInt has a lot of missing docs so I will do that in a separate PR. We also have the chance here to rename the functions into more descriptive ones, if we want. lsl => logicalShiftLeft if we later on have operators for those functions anyway it would not matter as much if the names are longer. |
We can "add", not rename Even we support infix ops, the shorter names are still useful for those who prefer the pipe style. |
@zth As mentioned in discord, I just keep it as it is. Merge? |
Got for it! |
1 similar comment
Got for it! |
I have no power here. If you moved Core over to the rescript org, I could do it. |
wait, I need to put them in their own submodule first |
No description provided.