Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Int: Add bitwise functions from Pervasives #245

Merged
merged 3 commits into from
Sep 8, 2024

Conversation

fhammerschmidt
Copy link
Member

No description provided.

@fhammerschmidt
Copy link
Member Author

@cometkim fyi

@cometkim
Copy link
Member

cometkim commented Sep 5, 2024

BigInt needs this too

@fhammerschmidt
Copy link
Member Author

BigInt has a lot of missing docs so I will do that in a separate PR.

We also have the chance here to rename the functions into more descriptive ones, if we want.

lsl => logicalShiftLeft
lsl => logicalShiftRght
lxor => logicalXor
etc.

if we later on have operators for those functions anyway it would not matter as much if the names are longer.

@cometkim
Copy link
Member

cometkim commented Sep 6, 2024

We also have the chance here to rename the functions into more descriptive ones, if we want.

We can "add", not rename

Even we support infix ops, the shorter names are still useful for those who prefer the pipe style.

@fhammerschmidt
Copy link
Member Author

@zth As mentioned in discord, I just keep it as it is. Merge?

@zth
Copy link
Collaborator

zth commented Sep 6, 2024

Got for it!

1 similar comment
@zth
Copy link
Collaborator

zth commented Sep 6, 2024

Got for it!

@fhammerschmidt
Copy link
Member Author

I have no power here. If you moved Core over to the rescript org, I could do it.

@fhammerschmidt
Copy link
Member Author

wait, I need to put them in their own submodule first

@zth zth merged commit 98eb2e8 into rescript-lang:main Sep 8, 2024
6 checks passed
@fhammerschmidt fhammerschmidt deleted the int-bitwise branch September 11, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants