Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add String.replaceAll and String.replaceAllRegExp #163

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

fhammerschmidt
Copy link
Member

@fhammerschmidt fhammerschmidt commented Nov 27, 2023

While replaceAllRegExp is not that useful since you can just do the normal one with the /g flag, the string one is a very welcome addition imo.

@zth
Copy link
Collaborator

zth commented Nov 27, 2023

Excellent, have been thinking about these as well! Ready to go?

@fhammerschmidt
Copy link
Member Author

Yes.
I just wished we had a way to check at compile time that a g flag is provided in replaceAllRegExp. Runtime errors are not really the ReScript way.

@zth zth merged commit c2fa6d3 into rescript-lang:main Nov 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants