Add attr res.syntaxSugar to Array.{get, set}
#6343
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspeddro
changed the title
res.syntaxSugar to `Array.{get, setres.syntaxSugar to Array.{get, set}
|
@aspeddro Shall we resurrect this PR? Would you rebase it, add a comment somewhere explaining what the attribute is used for, and a CHANGELOG entry? |
aspeddro
force-pushed
the
add-attr-syntax-sugar-array
branch
from
e4785d1
to
01926ab
Compare
|
I added a comment and updated the PR |
|
Thanks a lot! 👍 Regarding the comment, I meant in the code, where this attribute is set. Something else I am wondering about: The name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding attribute because the internal representation of
arr[idx]isArray.getand we don't have a way to distinguish both when issuing the token on the LSP.See rescript-lang/rescript-vscode#801