[Super errors] Remove dependency on Format for the code frame display #5013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a mostly feature-compatible refactor of super_misc, which is used to display the code frame in super errors reporting. I've optimized, and added useless features, to keep the tests mostly still intact so that this can be merged more comfortably. After this gets merged, I'll clean up some more logic. Changes: - No more Format. - No more need to patch compiler for colors (will do this in the next diffs). - Less need to understand the intricacies of coloring. It's now mostly encapsulate within this module.
|
If you are sure of no regressions I am fine. Note the benefit is unclear since Format is heavily used in the compiler codebase which seems impossible to be eliminated |
|
Yeah I'm not trying to eliminate Format for the sake of it. Just that it'll reduce some maintenance burden all around since this doesn't need compiler patches and other copy pasting concerns for the syntax repo anymore. Regarding regressions: the tests have a decent coverage, though I couldn't find an error from us that needs recursive error reporting. |
chenglou
added a commit
to chenglou/rescript-compiler
that referenced
this pull request
Mar 19, 2021
This is technically a small bug from way back. The recent refactor rescript-lang#5013 allowed us to fix this.
chenglou
added a commit
that referenced
this pull request
Mar 19, 2021
This is technically a small bug from way back. The recent refactor #5013 allowed us to fix this.
chenglou
added a commit
to chenglou/rescript-compiler
that referenced
this pull request
Mar 19, 2021
chenglou
added a commit
that referenced
this pull request
Mar 19, 2021
chenglou
added a commit
to chenglou/rescript-compiler
that referenced
this pull request
Mar 19, 2021
Fixes part of rescript-lang/rescript-vscode#86 Previous to rescript-lang#5013 we couldn't fix this issue because we used Format to break lines for us. Now that we're controlling this manually, we can draw the gutter for those lines.
chenglou
added a commit
that referenced
this pull request
Mar 19, 2021
Fixes part of rescript-lang/rescript-vscode#86 Previous to #5013 we couldn't fix this issue because we used Format to break lines for us. Now that we're controlling this manually, we can draw the gutter for those lines.
chenglou
added a commit
to chenglou/rescript-compiler
that referenced
this pull request
Mar 19, 2021
chenglou
added a commit
that referenced
this pull request
Mar 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Super errors] Remove dependency on Format for the code frame display
This is a mostly feature-compatible refactor of super_misc, which is used to display the code frame in super errors reporting. I've optimized, and added useless features, to keep the tests mostly still intact so that this can be merged more comfortably. After this gets merged, I'll clean up some more logic.
Changes: