Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mp4 parsing **a lot** faster & tremendously lower memory overhead #7860

Merged
merged 13 commits into from
Oct 22, 2024
Merged

Make mp4 parsing **a lot** faster & tremendously lower memory overhead #7860

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e24d9a1
don't copy mp4 data
jprochazk Oct 22, 2024
9b7c972
fix `frames` example
jprochazk Oct 22, 2024
ef01c8e
fix lint + add comment
jprochazk Oct 22, 2024
ffdd963
`video_data` -> `video_blob`
jprochazk Oct 22, 2024
da12cd3
`video_data` -> `video_blob`
jprochazk Oct 22, 2024
f735952
add benchmark
jprochazk Oct 22, 2024
800ad13
make it a thing
jprochazk Oct 22, 2024
d9d235f
Merge branch 'main' into jan/zerocopy-mp4-read
jprochazk Oct 22, 2024
7e3bdf1
update rev
jprochazk Oct 22, 2024
c02b1ef
fix lint
jprochazk Oct 22, 2024
6fedb6f
run benches under pixi
jprochazk Oct 22, 2024
562a7ab
wrong lint name
jprochazk Oct 22, 2024
ad4afc1
less bad
jprochazk Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions crates/store/re_video/benches/video_load_bench.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,8 @@ use criterion::{criterion_group, criterion_main, Criterion};

fn video_load(c: &mut Criterion) {
let video_path = Path::new(env!("CARGO_MANIFEST_DIR"))
.parent()
.unwrap()
.parent()
.unwrap()
.parent()
.ancestors()
.nth(3)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

.unwrap()
.join("tests/assets/video/Big_Buck_Bunny_1080_10s_av1.mp4");
let video = std::fs::read(video_path).unwrap();
Expand Down
Loading