Dataframe API v2 p1: API definitions #7559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
🔍 re_query
6 tasks
teh-cmc
force-pushed
the
cmc/dataframev2_1_api_def
branch
from
18886e3
to
a989ac2
Compare
jleibs
approved these changes
Oct 1, 2024
| @@ -242,6 +242,8 @@ pub struct ComponentColumnDescriptor { | |||
| pub store_datatype: ArrowDatatype, | |||
|
|
|||
| /// How the data will be joined into the resulting `RecordBatch`. | |||
| // | |||
| // TODO(cmc): remove with the old re_dataframe. | |||
There was a problem hiding this comment.
Why? I believe we still need this.
There was a problem hiding this comment.
Right now the API is a row iterator, there's nothing to join 🤷
| #[derive(Debug, Clone, PartialEq, Eq, Hash)] | ||
| pub struct ControlColumnSelector { | ||
| /// Name of the control column. | ||
| // | ||
| // TODO(cmc): this should be `component_name`. |
There was a problem hiding this comment.
That seems like an unnecessary verbosity. We generally refer to components by name. For example, we write things like "The Point3D component" and consider it synonymous with "The component named Point3D".
There was a problem hiding this comment.
Right now the convention across the codebase is that component the actual component data (component: impl Component) whereas component_name is just a name (component_name: ComponentName).
| /// view contents: it is possible to end up with values from outside the view! | ||
| LatestAtGlobal, | ||
| // | ||
| // TODO(cmc): `LatestAtView`? |
There was a problem hiding this comment.
👍 or more importantly, LatestAtWindowed(...)
Co-authored-by: Jeremy Leibs <[email protected]>
teh-cmc
force-pushed
the
cmc/dataframev2_1_api_def
branch
from
7d1cb72
to
39cfb1a
Compare
Co-authored-by: Jeremy Leibs <[email protected]>
teh-cmc
added a commit
that referenced
this pull request
Oct 2, 2024
A first implementation of the new dataframe APIs. The name is now very misleading though: there isn't anything dataframe-y left in here, it is a row-based iterator with Rerun semantics baked in, driven by a sorted streaming join. It is rather slow (related: #7558 (comment)), lacks many features and is full of edge cases, but it works. It does support dedupe-latest semantics (slowly), view contents and selections, chunk overlaps, and pagination (horribly, by virtue of implementing `Iterator`). It does _not_ support `Clear`s, nor `latest-at` sparse-filling, nor PoVs, nor index sampling. Yet. Upcoming PRs will be all about fixing these shortcomings one by one. It should look somewhat familiar: ```rust let query_cache = QueryCache::new(store); let query_engine = QueryEngine { store, cache: &query_cache, }; let mut query = QueryExpression2::new(timeline); query.view_contents = Some( query_engine .iter_entity_paths(&entity_path_filter) .map(|entity_path| (entity_path, None)) .collect(), ); query.filtered_index_range = Some(ResolvedTimeRange::new(time_from, time_to)); eprintln!("{query:#?}:"); let query_handle = query_engine.query(query.clone()); // eprintln!("{:#?}", query_handle.selected_contents()); for batch in query_handle.into_batch_iter().skip(offset).take(len) { eprintln!("{batch}"); } ``` No tests until we have the guarantee that these are the semantics we will commit to. * Part of #7495 * Requires #7559
teh-cmc
changed the title
teh-cmc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new public API definition and nothing else. Speak now.
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.