Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Image to use ImageBuffer instead of Blob #7102

Merged
merged 6 commits into from
Aug 8, 2024
Merged

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Aug 7, 2024

What

Using a dedicated ImageBuffer component means when we encounter ImageBuffer we know to look for an ImageFormat. This simplifies some of the future things related to data previews or eventually component-wise data-dependencies.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs added 🔩 data model exclude from changelog PRs with this won't show up in CHANGELOG.md labels Aug 7, 2024
@jleibs jleibs marked this pull request as ready for review August 7, 2024 16:56
Copy link

github-actions bot commented Aug 7, 2024

Deployed docs

Commit Link
9bcff89 https://landing-hruziyxz3-rerun.vercel.app/docs

@emilk
Copy link
Member

emilk commented Aug 8, 2024

This is something we might want to revert once we have tagged components:

@emilk emilk merged commit 0a13238 into main Aug 8, 2024
40 of 41 checks passed
@emilk emilk deleted the jleibs/image_buffer branch August 8, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔩 data model exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants