Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest egui master, with fixes for notebook focus #6674

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Jun 27, 2024

What

Instructions:

pixi run -e examples py-build-notebook
pixi run -e examples jupyter notebook examples/python/notebook/cube.ipynb

Run the first few 3 cells.

Known issues:

  • Hitting 'a' when the viewer selected still bypasses Rerun and adds a new preceding cell in the notebook. This is because of how Jupyter Notebook Classic does things.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk changed the title WIP: Integrate with egui-#4718 WIP: Integrate web/notebook focus fixes from egui Jun 28, 2024
@emilk emilk changed the title WIP: Integrate web/notebook focus fixes from egui Update to latest egui master, with fixes for notebook focus Jun 28, 2024
@emilk emilk marked this pull request as ready for review June 28, 2024 13:05
@emilk emilk added dependencies concerning crates, pip packages etc exclude from changelog PRs with this won't show up in CHANGELOG.md egui Requires egui/eframe work 🕸️ web regarding running the viewer in a browser notebook Jupyter notebooks etc labels Jun 28, 2024
@emilk emilk merged commit fbae12c into main Jun 28, 2024
37 of 45 checks passed
@emilk emilk deleted the jleibs/test_canvas_events branch June 28, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies concerning crates, pip packages etc egui Requires egui/eframe work exclude from changelog PRs with this won't show up in CHANGELOG.md notebook Jupyter notebooks etc 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rerun notebook widget eavesdrops on keyboard events while typing in another cell
3 participants