Use list_item for the component list in InstancePath::data_ui
#6309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abey79
force-pushed
the
antoine/list-item-component-list
branch
2 times, most recently
from
d994e2e to
06573e2
Compare
|
before screenshots would be nice. my memory is pretty bad with these things :) |
Done (though visually it doesn't make such a difference on screenshots) |
This was referenced May 15, 2024
emilk
approved these changes
May 20, 2024
Deployed docs
|
abey79
force-pushed
the
antoine/list-item-component-list
branch
from
3ee706f to
d2e86d1
Compare
# Conflicts: # crates/re_data_ui/src/component_ui_registry.rs # crates/re_data_ui/src/lib.rs
abey79
changed the title
list_item2 for the component list in InstancePath::data_uilist_item for the component list in InstancePath::data_ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
ListItemstyle for the component list (in the Selection Panel when an entity is selected) #4161PropertyContent#6325This PR uses
list_itemfor the component list in the entity path selection panel and tooltip.Blocked by emilk/egui#4471 to resolve the tooltip "first frame flicker"TODO:
selection panel
before:
after:
Note: the hover behaviour is the biggest change here: now full span, previously just on the left-column button
tooltip
before:
after:
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.