Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always point to versioned manifest when building a versioned binary #4781

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Always point to versioned manifest when building a versioned binary #4781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions crates/re_viewer/src/ui/welcome_screen/example_page.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,16 +133,17 @@ fn default_manifest_url() -> String {
let build_info = re_build_info::build_info!();
let short_sha = build_info.short_git_hash();

if build_info.is_in_rerun_workspace {
// Always point to `version/main` for rerun devs,
// because the current commit's manifest is unlikely to be uploaded to GCS.
"https://app.rerun.io/version/main/examples_manifest.json".into()
} else if build_info.version.is_rc() || build_info.version.is_release() {
// Point to the current version's manifest
if build_info.version.is_rc() || build_info.version.is_release() {
// If this is versioned as a release or rc, always point to the versioned
// example manifest. This applies even if doing a local source build.
format!(
"https://app.rerun.io/version/{version}/examples_manifest.json",
version = build_info.version,
)
} else if build_info.is_in_rerun_workspace {
// Otherwise, always point to `version/main` for rerun devs,
// because the current commit's manifest is unlikely to be uploaded to GCS.
"https://app.rerun.io/version/main/examples_manifest.json".into()
} else if !short_sha.is_empty() {
// If we have a sha, try to point at it.
format!("https://app.rerun.io/commit/{short_sha}/examples_manifest.json")
Expand Down
Loading