Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix group selection/hover with data queries #4643

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Fix group selection/hover with data queries #4643

merged 1 commit into from
Jan 3, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Jan 2, 2024 •
edited
Loading

What

Restores the behavior of group hover/selection using the cached data query result.

Also removes some deprecated TODOs.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jleibs jleibs added 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 2, 2024
@jleibs jleibs marked this pull request as ready for review January 2, 2024 19:40
@jleibs jleibs merged commit ea63a88 into main Jan 3, 2024
40 of 46 checks passed
@jleibs jleibs deleted the jleibs/blueprint_cleanup branch January 3, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pay off accumulated debt from DataQuery refactor
1 participant
@jleibs