Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fit the graph bounding box to the view unless user overrides #8429

Closed
grtlr opened this issue Dec 12, 2024 · 0 comments · Fixed by #8438
Closed

Fit the graph bounding box to the view unless user overrides #8429

grtlr opened this issue Dec 12, 2024 · 0 comments · Fixed by #8438
Labels
enhancement New feature or request ui concerns graphical user interface
Milestone
0.21 - Graph View...

Comments

@grtlr
Copy link
Contributor

grtlr commented Dec 12, 2024

This would prevent graphs to be only partially shown during layout.
@grtlr grtlr added enhancement New feature or request ui concerns graphical user interface labels Dec 12, 2024
@grtlr grtlr mentioned this issue Dec 12, 2024
Merged
grtlr added a commit that referenced this issue Dec 13, 2024
@grtlr @Wumpf
Improve VisualBounds2D behavior in graph view (#8438)
1684190 
* Closes #8429

This implements improved handling of `VisualBounds2D`. Specifically, it:

* Always defaults to the data bounds when user has not modified the view
(@nikolausWest's suggestion).
* Zooms in and out of view when resizing the view (@abey79's
suggestion).
* Fixes the `VisualBounds2D` selection panel bug (submitted by @Wumpf)

---------

Co-authored-by: Andreas Reich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request ui concerns graphical user interface
Projects
None yet
Milestone
0.21 - Graph View, Grid, Undo, Breadc...
Development

Successfully merging a pull request may close this issue.

Improve VisualBounds2D behavior in graph view rerun-io/rerun
1 participant
@grtlr