Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marking of edited for the blueprint is error prone #4687

Closed
jleibs opened this issue Jan 5, 2024 · 1 comment · Fixed by #8241
Closed

Marking of edited for the blueprint is error prone #4687

jleibs opened this issue Jan 5, 2024 · 1 comment · Fixed by #8241
Assignees
@emilk
Labels
🟦 blueprint The data that defines our UI 🚜 refactor Change the code, not the functionality
Milestone
Triage

Comments

@jleibs
Copy link
Member

jleibs commented Jan 5, 2024

There are several places where viewport edit-tracking is done manually.

This carries a significant risk that a logic error can result in a never-ending sequence of blueprint re-saving. This can happen if
(1) the edit marking happens without a user interaction
(2) the saved state as a result of the edit does not result in a new state where the edit is no longer marked.
@jleibs jleibs added 🚜 refactor Change the code, not the functionality 🟦 blueprint The data that defines our UI labels Jan 5, 2024
@jleibs jleibs mentioned this issue Jan 5, 2024
Merged
4 tasks
@emilk
Copy link
Member

emilk commented Jan 5, 2024

Related:

emilk pushed a commit that referenced this issue Jan 5, 2024
@jleibs
Reflect visibillity in the container tree and fix blueprint-edit-loop (…
cd776fa 
…#4688)

### What
 - Resolves: #4684
 - Resolves: #4692
 - Resolves: #4693

Also fixes a bug where rare edge-cases of the blueprint would get into
an infinite edit loop.
Added an issue and TODOs to avoid this issue:
 - #4687


![image](https://github.com/rerun-io/rerun/assets/3312232/2e329288-81a9-4ed4-b423-d4fa1dcd07cf)


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4688/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4688/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4688/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4688)
- [Docs
preview](https://rerun.io/preview/38c5dd05c23a3ee65e80f2704ec08841c77bd0ef/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/38c5dd05c23a3ee65e80f2704ec08841c77bd0ef/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
@nikolausWest nikolausWest added this to the Triage milestone Jan 30, 2024
@emilk emilk mentioned this issue Nov 11, 2024
Closed
@emilk emilk self-assigned this Nov 27, 2024
@emilk emilk mentioned this issue Nov 28, 2024
Merged
@emilk emilk closed this as completed in d6aebd6 Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
🟦 blueprint The data that defines our UI 🚜 refactor Change the code, not the functionality
Projects
None yet
Milestone
Triage
Development

Successfully merging a pull request may close this issue.

Refactor convoluted ViewportBlueprint logic rerun-io/rerun
3 participants
@emilk @nikolausWest @jleibs