Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue: Visible History feature #4107

Open
8 of 21 tasks
abey79 opened this issue Nov 1, 2023 · 0 comments
Open
8 of 21 tasks

Tracking issue: Visible History feature #4107

abey79 opened this issue Nov 1, 2023 · 0 comments
Labels
🎄 tracking issue issue that tracks a bunch of subissues ui concerns graphical user interface

Comments

@abey79
Copy link
Member

abey79 commented Nov 1, 2023 •
edited
Loading

Features/Improvements

Missing coverage

Bug/Annoying behaviour

Implementation

Related

Supersedes:
@abey79 abey79 added ui concerns graphical user interface 🎄 tracking issue issue that tracks a bunch of subissues labels Nov 1, 2023
This was referenced Nov 2, 2023
Closed
Merged
Closed
abey79 added a commit that referenced this issue Nov 6, 2023
@abey79 @Wumpf
Improve Visible History to support more general time queries (#4123)
ce2493c 
### What

* Fixes #3933

<img width="1971" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/8d51f828-cab8-4940-9a2a-a35841fb7fe2">


#### Scope
- Improve the "Visible History" feature to build more general time
queries:
  - Control both start/end time boundaries
  - relative/absolute/full mode for each boundaries
  - explicit active/inactive state/checkbox
- Improve usability:
  - Proper scaling and bounds for the 'DragValue` widgets 
- Proper cascading behaviour from data group(s) to entity: a child's
"visible history" settings will override the parent's if the feature is
active.
  - Do not display Visible History UI in places where it's not supported

#### Out-of-scope
- Add support for Visible History to space views other than 2D/3D
- Add Visible History UI to 3D/2D space view themselves (for consistency
with what precedes and to address some corner cases)
- Add (read-only) shading in the time panel
- Fix the numerous issues/missing features listed in:
  - #4107

#### TODO
- [x] fine-tune the UI layout
- [x] discuss/implement heuristics to decide whether or not to display
the UI
- [x] add information notices (e.g. "this applies to ALL sequence
timelines")

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4123) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4123)
- [Docs
preview](https://rerun.io/preview/6bc0ba72dc79b5af782d73cbabb09b670c59b7e3/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/6bc0ba72dc79b5af782d73cbabb09b670c59b7e3/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)

---------

Co-authored-by: Andreas Reich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎄 tracking issue issue that tracks a bunch of subissues ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abey79